Re: [LinuxBIOS] [PATCH] AMD Barcelona(family 10) support 1 of 4 repost

[Marc Jones]

Myles Watson wrote:
> Index: LinuxBIOSv2/src/cpu/amd/car/cache_as_ram.inc
>
> ...
> movl	%edx, %eax
> wrmsr
> movl	$0x269, %ecx
> wrmsr
>
> Extra tab before wrmsr

fixed
> +#if CAR_FAM10 == 1
> +#define CacheSizeAPStack 0x400 /* 1K */
> +//#define CacheSizeAPStack 0x200 /* 512 */
> +#endif
>
> A comment of when you might want to switch to 512 would be nice, or just
> remove the 512.

and fixed
> I don't have the hardware to test with Barcelona, but the patch doesn't
> change the functionality of the base code (except for adding some POST
> codes).
>
> Thanks for separating the patches, it made it a lot easier to see the
> changes.
>
> Myles
>
> Acked-by: Myles Watson

Thanks,
Marc