Ward Vandewege wrote:
I'm not sure adding a post code to 'die' is a good idea. The problem with doing that is that it would clobber any previous post codes, which might be a better indicator for what's going wrong.
I think it is important to have a special POST code for use in die() to positively identify that that is really where the code has hung.
Stefan Reinauer wrote:
We could add a post code to the parameters of the die() function.
I think this is a good idea, and I would like to suggest that die() does the following:
void die(u8 post) { while(1) { post_code(0xdd); mdelay(700); post_code(post); mdelay(700); } }
There is no printk() which is sad. I think it's better to only use POST codes if that is the only reliable output method, but I think it's a lot better if the print functions can just be made to not hang if called before they can actually output something. That would need a bit more work though, so for now I'd like to suggest the above.
//Peter