Move /* for on board device with embedded ROM image, the ROM image is at * fixed address specified in the Config.lb, the dev->rom_address is * inited by driver_pci_onboard_ops::enable_dev() */ if ((dev->on_mainboard) && (dev->rom_address != 0)) { resource->base = dev->rom_address; resource->flags |= IORESOURCE_MEM | IORESOURCE_READONLY | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; return; }
To get_pci_rom_resource end.
PCI: 02:06.0 30 <- [0x00fff80000 - 0x00fff9ffff] rom
But PCI: 02:06.0 init pci_rom_probe, rom address for PCI: 02:06.0 = 1d300 pci_rom_probe, Incorrect Expansion ROM Header Signature 1fe8
I wonder if we can not store that value into PCI_ROM_ADDRESS
YH
-----Original Message----- From: YhLu Sent: Thursday, January 13, 2005 10:06 AM To: YhLu; Li-Ta Lo Cc: Sagiv Yefet; LinuxBIOS Subject: RE: Running with VGA
I guess it can not get size correctly. So you need to change the pci_get_rom_resource to get the size for it.
And then assign the base to it.
YH
-----Original Message----- From: YhLu Sent: Thursday, January 13, 2005 9:49 AM To: Li-Ta Lo Cc: Sagiv Yefet; LinuxBIOS Subject: RE: Running with VGA
PCI: 02:06.0 30 <- [0x00fff80000 - 0x00fff7ffff] rom
It seems it can not be processed by pci_set_resource properly.
YH
-----Original Message----- From: Li-Ta Lo [mailto:ollie@lanl.gov] Sent: Wednesday, January 12, 2005 10:10 PM To: YhLu Cc: Sagiv Yefet; LinuxBIOS Subject: RE: Running with VGA
On Wed, 2005-01-12 at 23:07, YhLu wrote:
You assign the value to the new resource.
I wonder if it will confuse the resource allocator. Because the range is
out
of touch of allocator.
I don't think so but I am not sure neither. The resource is flagged as FIXED and ASSIGNED. The resource allocator should leave that resource as is. If it does not work, we can just write dev->rom_address to PCI_ROM_ADDRESS directly in pci_get_rom_resource() and the pci_rom_probe() can still be unchanged.
Could you try the code?
Ollie
YH
-----Original Message----- From: Li-Ta Lo [mailto:ollie@lanl.gov] Sent: Wednesday, January 12, 2005 9:48 PM To: YhLu Cc: Sagiv Yefet; LinuxBIOS Subject: RE: Running with VGA
On Wed, 2005-01-12 at 21:02, YhLu wrote:
Committed.
Also I added readme in /drivers/pci/onboard/onboard.c
YH
I made some modification which should utilize the resource allocation code and minimize the impact of the embedded ROM image. I was doing it blindly, please test it on your platform.
Ollie
_______________________________________________ Linuxbios mailing list Linuxbios@clustermatic.org http://www.clustermatic.org/mailman/listinfo/linuxbios