On 02.05.19 08:10, Martin Kepplinger wrote:
On 25.04.19 12:23, Patrick Georgi via coreboot wrote:
There was some recent cleanup on console.h includes that makes printk only visible where we thought it was needed. A change to add an include for console/console.h to resolve the issue here. Cc'ing Elyes since that's his effort.
As you correctly noticed, x86emu isn't build-tested by default: If you want, you could contribute a patch to add your config to configs/, which makes it build tested by default to avoid future regressions in the x86emu code.
The initial failure is fixed, thanks. Adding a config that uses x86emu isn't trivial in this case since x86emu is used to run a nonfree vbios option rom that isn't part of our blobs repo...
The options to run OpROMs are independent from those that add binaries. This simple config works for instance:
CONFIG_VENDOR_ESD=y CONFIG_PCI_OPTION_ROM_RUN_YABEL=y
Nico