Re: [coreboot] [PATCH] Make hidden configuration flags visible (i945)

[Myles Watson]

On Thu, Sep 30, 2010 at 4:31 PM, Patrick Georgi  wrote:
> Am 01.10.2010 00:24, schrieb Myles Watson:
> > +choice
> > prompt "Chipset variant"
> > default I945GM
> > depends on NORTHBRIDGE_INTEL_I945
> > help
> > Different i945 variants require slightly different setup.
> >
> > +config I945GM
> > bool "i945GM (Mobile) chipset"
> >
> > +config I945GC
> > bool "i945GC chipset"
> >
> > +endchoice
> >
> > I don't think this should be exposed to the user.  A board Kconfig
> > should select it, but there shouldn't be a menu prompt for it.
>
> How to make it invisible, simply by removing the "prompt"? My primary
> interest was in using choice to make sure Kconfig allows only either of
> the values.

If that works, it's fine with me.  Otherwise, if there's only these
two variants, it could be collapsed to a single Kconfig option.  I
just think it's good to avoid options that are never correct in
user-visible Kconfig.

Thanks,
Myles