On Tue, May 15, 2007 at 06:00:28PM +0200, Stefan Reinauer wrote:
Should they return uint8_t perhaps?
Yes, I think so. AFAIK smbus works with byte values (or at least smbus_read_byte() does), and SPD data consists of bytes, too...
Most other romcc functions have no sized variables, but just signed/unsigned.
Yuck. Maybe we should leave this for v3, as romcc seems to be a lot nastier than I would have expected. I'm reluctant to touch any of this stuff anymore without a good reason (but I don't want to hold off others who want to provide patches).
Uwe.