Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

[Stefan Reinauer]

* Patrick Georgi  [110225 22:37]:
> Am 25.02.2011 22:10, schrieb Stefan Reinauer:
> > > > static inline void smbus_delay(void)
> > > >    {
> > > > outb(0x80, 0x80);
> > > > post_code(POST_SMBUS_DELAY);
> > > > }
> >
> > This should not be an outb to 0x80 at all, as it does not reflect a
> > "post_code" debug message but rather a delay. I suggest that you either
> > use an inb(0x80) or an outb to port 0xeb or something instead.
>
> He asked on #coreboot about this, and I told him to do it this way
> (or not change those outbs at all), as long as the smbus_* functions
> that are the same stay the same (for future refactorings, see
> Infrastructure Projects).
> Of course, inb 0x80 or outb 0xeb would be nicer (as that doesn't
> spam POST), but IMHO we had this for so long and it didn't seriously
> hurt, and can survive some more.

Hm. If we touch it now, why not fix it so we don't have to care anymore?
Some smbus drivers (like the ICH7 one) are using inb already, and it
works fine.