Re: [coreboot] New patch to review for coreboot: 7d2dd95 superiotool: Add support for NCT6775F and NCT6779D

[Guenter Roeck]

On Fri, Jun 29, 2012 at 09:52:48PM +0200, Paul Menzel wrote:
> Dear Günter,
>
> thank you for your patches.
>
> Am Freitag, den 29.06.2012, 21:31 +0200 schrieb Guenter Roeck:
> > Guenter Roeck ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1148
> >
> > -gerrit
> >
> > commit 7d2dd956c42b0d043fae3167bc17471a26c131db
> > Author: Guenter Roeck 
> > Date:   Fri Jun 29 12:22:51 2012 -0700
> > superiotool: Add support for NCT6775F and NCT6779D
>
> Maybe add A/B to the first chip so that it is clear that three chips are
> added. (Next time a separate patch for each patch would be also nice I
> think.)

Hi Paul,

Sure, no problem. It isn't really three chips, though; I don't really count
chip revisions as separate chip. Only reason for listing both revisions
of NCT6775F separately is to follow the existing code.
> Could you add send the output of `superiotool -V` for all three chips to
> the *list*? Maybe as a reply to this status message. That would be
> awesome.

Please see attached for NCT6775F. I'll send the one for NCT6776F tonight.
For NCT6779D I rely on others for testing, so it may take a while until
I can get the log.
> Lastly, are the data sheets available somewhere?

Data sheets are available from Nuvoton upon request. You'll have to ask nicely
and tell them why you need it, then they are usually quite helpful.
> > Change-Id: I66667fcb58f6885460021f4a2024d6ba56b95f11
> > Signed-off-by: Guenter Roeck <[e-mail]>
> >
> > util/superiotool/nuvoton.c |  234 ++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 234 insertions(+), 0 deletions(-)
>
> Otherwise this looks good. Thanks again.

Thanks,
Guenter