New patch to review for coreboot: 7d2dd95 superiotool: Add support for NCT6775F and NCT6779D
Guenter Roeck (linux@roeck-us.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1148
-gerrit
commit 7d2dd956c42b0d043fae3167bc17471a26c131db Author: Guenter Roeck linux@roeck-us.net Date: Fri Jun 29 12:22:51 2012 -0700
superiotool: Add support for NCT6775F and NCT6779D
Change-Id: I66667fcb58f6885460021f4a2024d6ba56b95f11 Signed-off-by: Guenter Roeck linux@roeck-us.net --- util/superiotool/nuvoton.c | 234 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 234 insertions(+), 0 deletions(-)
diff --git a/util/superiotool/nuvoton.c b/util/superiotool/nuvoton.c index ed2eabc..46b8c2a 100644 --- a/util/superiotool/nuvoton.c +++ b/util/superiotool/nuvoton.c @@ -66,6 +66,170 @@ static const struct superio_registers reg_table[] = { {EOT}}}, {0x1a, "WPCM450", { {EOT}}}, + {0xb472, "NCT6775F (A)", { + {NOLDN, NULL, + {0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28, + 0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, + {0xb4,0x72,0xff,0x78,0x40,0x00,0x00,0x7d,0x00, + 0x00,0x58,0x77,0xfc,0x04,0x00,MISC,EOT}}, + {0x00, "FDC", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4, + 0xf5,EOT}, + {0x03,0x03,0xf0,0x06,0x02,0x8e,0x00,0xff,0x00, + 0x00,EOT}}, + {0x01, "Parallel Port", + {0x30,0x60,0x61,0x70,0x74,0xf0,EOT}, + {0x01,0x03,0x78,0x07,0x04,0x3f,EOT}}, + {0x02, "UART A", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x01,0x03,0xf8,0x04,0x00,EOT}}, + {0x03, "UART B, IR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,EOT}, + {0x01,0x02,0xf8,0x03,0x00,0x00,EOT}}, + {0x05, "Keyboard Controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}}, + {0x06, "CIR", + {0x30,0x60,0x61,0x70,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0x07, "GPIO6, GPIO7, GPIO8, GPIO9", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7, + 0xe8,0xe9,0xea,0xeb,0xec,0xed,0xee,0xf4,0xf5, + 0xf6,0xf7,0xf8,EOT}, + {0x18,0xff,0x00,0x00,0x00,0xef,0x00,0x00,0x00, + 0xff,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00, + 0x00,0x00,0x00,EOT}}, + {0x08, "WDT1, GPIO0, GPIO1", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xf0, + 0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,EOT}, + {0x00,0xff,0x00,0x00,0x00,0x00,0xff, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x09, "GPIO2, GPIO3, GPIO4, GPIO5", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7, + 0xe8,0xe9,0xea,0xeb,0xee,0xf0,0xf1,0xf2,0xf4, + 0xf5,0xf6,0xf7,0xfe,EOT}, + {0x05,0xff,0x00,0x00,0x00,0xff,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff, + 0x00,0x00,0x00,0x00,EOT}}, + {0x0a, "ACPI", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7, + 0xe8,0xe9,0xea,0xeb,0xed,0xf2,0xf3,0xf4,0xf6, + 0xf7,0xfe,EOT}, + {0x00,0x01,0x00,0x00,0x00,0x00,0x02,0x1c,0x00, + 0x00,0x00,0x00,0x00,0x00,0x7c,0x00,0x00,0x00, + 0x20,0x00,EOT}}, + {0x0b, "Hardware Monitor, Front Panel LED", + {0x30,0x60,0x61,0x62,0x63,0x70,0xf0,0xf1,0xf2, + 0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb, + 0xfc,0xfd,0xfe, + EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0xc1,0x00,0x00, + 0x00,0x00,0x10,0x00,0x87,0x47,0x00,0x00,0x00, + 0x00,0x00,0x00, + EOT}}, + {0x0c, "PECI, SST", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9, + 0xee,0xef,0xf1,0xf2,0xf3,0xfa,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01,0x0f, + 0x47,0x5b,0x40,0x50,0x10,0x00,EOT}}, + {0x0d, "VID, VIDDAC, BUSSEL", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xeb, + 0xec,0xed,0xee,0xef,0xf3,0xf4,0xf5,0xf6,0xf7, + 0xf8,0xf9,EOT}, + {0x00,0x00,0x00,0x00,0x07,0x00,0x00,0x00,0x14, + 0x01,0x00,0x88,0x00,0x00,0x00,0x00,0x07,0x00, + 0x00,0x00,EOT}}, + {0x0e, "CIR WAKE-UP", + {0x30,0x60,0x61,0x70,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0x0f, "GPIO Push-Pull or Open-drain", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8, + 0xe9,0xf0,0xf2,0xf3,0xf4,0xf8,0xfe,EOT}, + {0xff,0xff,0xf7,0xff,0xfb,0xcb,0xff,0xff,0xff, + 0xff,0x00,0x00,0x00,0x00,0x70,0xff,EOT}}, + {EOT}}}, + {0xb473, "NCT6775F (B)", { + {NOLDN, NULL, + {0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28, + 0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, + {0xb4,0x73,0xff,0x78,0x40,0x00,0x00,0x7d,0x00, + 0x00,0x58,0x77,0xfc,0x04,0x00,MISC,EOT}}, + {0x00, "FDC", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4, + 0xf5,EOT}, + {0x03,0x03,0xf0,0x06,0x02,0x8e,0x00,0xff,0x00, + 0x00,EOT}}, + {0x01, "Parallel Port", + {0x30,0x60,0x61,0x70,0x74,0xf0,EOT}, + {0x01,0x03,0x78,0x07,0x04,0x3f,EOT}}, + {0x02, "UART A", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x01,0x03,0xf8,0x04,0x00,EOT}}, + {0x03, "UART B, IR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,EOT}, + {0x01,0x02,0xf8,0x03,0x00,0x00,EOT}}, + {0x05, "Keyboard Controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}}, + {0x06, "CIR", + {0x30,0x60,0x61,0x70,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0x07, "GPIO6, GPIO7, GPIO8, GPIO9", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7, + 0xe8,0xe9,0xea,0xeb,0xec,0xed,0xee,0xf4,0xf5, + 0xf6,0xf7,0xf8,EOT}, + {0x18,0xff,0x00,0x00,0x00,0xef,0x00,0x00,0x00, + 0xff,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00, + 0x00,0x00,0x00,EOT}}, + {0x08, "WDT1, GPIO0, GPIO1", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xf0, + 0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,EOT}, + {0x00,0xff,0x00,0x00,0x00,0x00,0xff, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x09, "GPIO2, GPIO3, GPIO4, GPIO5", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7, + 0xe8,0xe9,0xea,0xeb,0xee,0xf0,0xf1,0xf2,0xf4, + 0xf5,0xf6,0xf7,0xfe,EOT}, + {0x05,0xff,0x00,0x00,0x00,0xff,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff, + 0x00,0x00,0x00,0x00,EOT}}, + {0x0a, "ACPI", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7, + 0xe8,0xe9,0xea,0xeb,0xed,0xf2,0xf3,0xf4,0xf6, + 0xf7,0xfe,EOT}, + {0x00,0x01,0x00,0x00,0x00,0x00,0x02,0x1c,0x00, + 0x00,0x00,0x00,0x00,0x00,0x7c,0x00,0x00,0x00, + 0x20,0x00,EOT}}, + {0x0b, "Hardware Monitor, Front Panel LED", + {0x30,0x60,0x61,0x62,0x63,0x70,0xf0,0xf1,0xf2, + 0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb, + 0xfc,0xfd,0xfe, + EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0xc1,0x00,0x00, + 0x00,0x00,0x10,0x00,0x87,0x47,0x00,0x00,0x00, + 0x00,0x00,0x00, + EOT}}, + {0x0c, "PECI, SST", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9, + 0xee,0xef,0xf1,0xf2,0xf3,0xfa,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01,0x0f, + 0x47,0x5b,0x40,0x50,0x10,0x00,EOT}}, + {0x0d, "VID, VIDDAC, BUSSEL", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xeb, + 0xec,0xed,0xee,0xef,0xf3,0xf4,0xf5,0xf6,0xf7, + 0xf8,0xf9,EOT}, + {0x00,0x00,0x00,0x00,0x07,0x00,0x00,0x00,0x14, + 0x01,0x00,0x88,0x00,0x00,0x00,0x00,0x07,0x00, + 0x00,0x00,EOT}}, + {0x0e, "CIR WAKE-UP", + {0x30,0x60,0x61,0x70,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0x0f, "GPIO Push-Pull or Open-drain", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8, + 0xe9,0xf0,0xf2,0xf3,0xf4,0xf8,0xfe,EOT}, + {0xff,0xff,0xf7,0xff,0xfb,0xcb,0xff,0xff,0xff, + 0xff,0x00,0x00,0x00,0x00,0x70,0xff,EOT}}, + {EOT}}}, {0xc332, "NCT6776F (B)", { {NOLDN, NULL, {0x10,0x11,0x13,0x14,0x16,0x17,0x18,0x19,0x1a, @@ -234,6 +398,76 @@ static const struct superio_registers reg_table[] = { {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,EOT}, {0x01,0x00,0x00,0x00,0x01,0x00,EOT}}, {EOT}}}, + {0xc562, "NCT6779D", { + {NOLDN, NULL, + {0x10,0x11,0x13,0x14,0x1a,0x1b,0x1c,0x1d,0x20, + 0x21,0x22,0x24,0x25,0x26,0x27,0x28,0x2a,0x2b, + 0x2c,0x2f,EOT}, + {0xff,0xff,0x00,0x00,0x30,0x70,0x10,0x00,0xc5, + 0x62,0xff,0x04,0x00,MISC,0x00,0x00,0xc0,0x00, + 0x01,MISC,EOT}}, + {0x01, "Parallel Port", + {0x30,0x60,0x61,0x70,0x74,0xf0,EOT}, + {0x01,0x03,0x78,0x07,0x04,0x3f,EOT}}, + {0x02, "UART A", + {0x30,0x60,0x61,0x70,0xf0,0xf2,EOT}, + {0x01,0x03,0xf8,0x04,0x00,0x00,EOT}}, + {0x03, "UART B, IR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT}, + {0x01,0x02,0xf8,0x03,0x00,0x00,0x00,EOT}}, + {0x05, "Keyboard Controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}}, + {0x06, "CIR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,0xf3,EOT}, + {0x00,0x00,0x00,0x00,0x08,0x09,0x32,0x00,EOT}}, + {0x07, "GPIO6, GPIO7, GPIO8", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7, + 0xec,0xed,0xf4,0xf5,0xf6,0xf7,0xf8,EOT}, + {0x0f,0x00,0x00,0x00,0xff,0x00,0x00,0x00, + 0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}}, + {0x08, "WDT1, GPIO0, GPIO1", + {0x30,0x60,0x61,0xe0,0xe1,0xe2,0xe3,0xe4,0xf0, + 0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,EOT}, + {0x00,0x00,0x00,0xff,0x00,0x00,0x00,0x00,0xff, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x09, "GPIO1, GPIO2, GPIO3, GPIO4, GPIO5, GPIO6, GPIO7, GPIO8", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7, + 0xe8,0xe9,0xea,0xeb,0xee,0xf0,0xf1,0xf2,0xf4, + 0xf5,0xf6,0xf7,0xfe,EOT}, + {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff, + 0x00,0x00,0x00,0x00,EOT}}, + {0x0a, "ACPI", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9, + 0xee,0xf0,0xf2,0xf3,0xf4,0xf6,0xf7,0xfe,EOT}, + {0x01,0x00,0x00,0x00,0x00,0x02,0x1c,0x00,0x00, + 0x00,0x10,0x5c,0x00,0x00,0x00,0xc0,0x00,EOT}}, + {0x0b, "Hardware Monitor, Front Panel LED", + {0x30,0x60,0x61,0x62,0x63,0x70,0xe0,0xe1,0xe2, + 0xe4,0xf0,0xf1,0xf2,0xf5,0xf6,0xf7,0xf8,0xf9, + 0xfa,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x7f,0x7f,0xff, + 0xff,0x00,0x00,0x00,0x10,0x00,0x87,0x47,0x00, + 0x00,EOT}}, + {0x0d, "WDT1", + {0xf0,EOT}, + {0x00,EOT}}, + {0x0e, "CIR WAKE-UP", + {0x30,0x60,0x61,0x70,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0x0f, "GPIO Push-Pull or Open-drain", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9, + 0xf0,0xf1,0xf2,EOT}, + {0xff,0xff,0x7f,0xff,0xff,0xff,0x0f,0xff,0xff, + 0x9d,0x00,0x00,EOT}}, + {0x14, "Port 80 UART", + {0xe0,0xe1,0xe2,0xe3,0xe4,EOT}, + {0x80,0x00,0x00,0x10,0x00,EOT}}, + {0x16, "Deep Sleep", + {0x30,0xe0,0xe1,0xe2,EOT}, + {0x20,0x20,0x04,0x05,EOT}}, + {EOT}}}, {EOT} };
Dear Günter,
thank you for your patches.
Am Freitag, den 29.06.2012, 21:31 +0200 schrieb Guenter Roeck:
Guenter Roeck (linux@roeck-us.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1148
-gerrit
commit 7d2dd956c42b0d043fae3167bc17471a26c131db Author: Guenter Roeck linux@roeck-us.net Date: Fri Jun 29 12:22:51 2012 -0700
superiotool: Add support for NCT6775F and NCT6779D
Maybe add A/B to the first chip so that it is clear that three chips are added. (Next time a separate patch for each patch would be also nice I think.)
Could you add send the output of `superiotool -V` for all three chips to the *list*? Maybe as a reply to this status message. That would be awesome.
Lastly, are the data sheets available somewhere?
Change-Id: I66667fcb58f6885460021f4a2024d6ba56b95f11 Signed-off-by: Guenter Roeck <linux@roeck-us.net>
util/superiotool/nuvoton.c | 234 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 234 insertions(+), 0 deletions(-)
Otherwise this looks good. Thanks again.
[…]
Thanks,
Paul
On Fri, Jun 29, 2012 at 09:52:48PM +0200, Paul Menzel wrote:
Dear Günter,
thank you for your patches.
Am Freitag, den 29.06.2012, 21:31 +0200 schrieb Guenter Roeck:
Guenter Roeck (linux@roeck-us.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1148
-gerrit
commit 7d2dd956c42b0d043fae3167bc17471a26c131db Author: Guenter Roeck linux@roeck-us.net Date: Fri Jun 29 12:22:51 2012 -0700
superiotool: Add support for NCT6775F and NCT6779DMaybe add A/B to the first chip so that it is clear that three chips are added. (Next time a separate patch for each patch would be also nice I think.)
Hi Paul,
Sure, no problem. It isn't really three chips, though; I don't really count chip revisions as separate chip. Only reason for listing both revisions of NCT6775F separately is to follow the existing code.
Could you add send the output of `superiotool -V` for all three chips to the *list*? Maybe as a reply to this status message. That would be awesome.
Please see attached for NCT6775F. I'll send the one for NCT6776F tonight. For NCT6779D I rely on others for testing, so it may take a while until I can get the log.
Lastly, are the data sheets available somewhere?
Data sheets are available from Nuvoton upon request. You'll have to ask nicely and tell them why you need it, then they are usually quite helpful.
Change-Id: I66667fcb58f6885460021f4a2024d6ba56b95f11 Signed-off-by: Guenter Roeck <linux@roeck-us.net>
util/superiotool/nuvoton.c | 234 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 234 insertions(+), 0 deletions(-)
Otherwise this looks good. Thanks again.
Thanks, Guenter
On Fri, Jun 29, 2012 at 09:52:48PM +0200, Paul Menzel wrote:
Dear Günter,
thank you for your patches.
Am Freitag, den 29.06.2012, 21:31 +0200 schrieb Guenter Roeck:
Guenter Roeck (linux@roeck-us.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1148
-gerrit
commit 7d2dd956c42b0d043fae3167bc17471a26c131db Author: Guenter Roeck linux@roeck-us.net Date: Fri Jun 29 12:22:51 2012 -0700
superiotool: Add support for NCT6775F and NCT6779DMaybe add A/B to the first chip so that it is clear that three chips are added. (Next time a separate patch for each patch would be also nice I think.)
Could you add send the output of `superiotool -V` for all three chips to the *list*? Maybe as a reply to this status message. That would be awesome.
Attached output for NCT6776F. Sorry, I didn't realize that you want to see the output for NCT6775F(A), ie the older revision. I don't have a system with that version of the chip. If that is an issue, let me know and I'll drop it from the patch.
Guenter
-
Guenter Roeck -
Guenter Roeck -
Paul Menzel