Paul Menzel (paulepanter@users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2375
-gerrit
commit 0cdcacbc4904a4f3e1034d51616c591d342f2986 Author: Paul Menzel paulepanter@users.sourceforge.net Date: Tue Feb 12 12:38:20 2013 +0100
Google Parrot/Butterfly: fadt.c: Align macros correctly
The commits adding support for the Google Parrot Chromebook
commit a7198b34ccf120df2a9e5b9f104812e96916ad08 Author: Stefan Reinauer reinauer@chromium.org Date: Tue Dec 11 16:00:47 2012 -0800
Add support for Google Parrot Chromebook
Reviewed-on: http://review.coreboot.org/2026
and the Google Butterfly Chromebook
commit d7bd4eb003f5b6a13943418ae0ac53248a2e34d2 Author: Stefan Reinauer reinauer@chromium.org Date: Mon Feb 11 11:11:36 2013 -0800
Add support for "Butterfly" Chromebook
Reviewed-on: http://review.coreboot.org/2359
had macros in `fadt.c` which were not aligned correctly and did not adhere to the coding style which uses just one space after `#define`.
Change-Id: I1422c57a3bdc2faa29d2a6e2064e4d3aeed0f1cb Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/mainboard/google/butterfly/fadt.c | 12 ++++++------ src/mainboard/google/parrot/fadt.c | 10 +++++----- 2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/mainboard/google/butterfly/fadt.c b/src/mainboard/google/butterfly/fadt.c index 59e67c2..b8da1be 100644 --- a/src/mainboard/google/butterfly/fadt.c +++ b/src/mainboard/google/butterfly/fadt.c @@ -25,12 +25,12 @@ * to be included by the ich7 smi handler, ich7 smi init * code and the mainboard fadt. */ -#define APM_CNT 0xb2 -#define CST_CONTROL 0x85 -#define PST_CONTROL 0x80 -#define ACPI_DISABLE 0x1e -#define ACPI_ENABLE 0xe1 -#define GNVS_UPDATE 0xea +#define APM_CNT 0xb2 +#define CST_CONTROL 0x85 +#define PST_CONTROL 0x80 +#define ACPI_DISABLE 0x1e +#define ACPI_ENABLE 0xe1 +#define GNVS_UPDATE 0xea
void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) { diff --git a/src/mainboard/google/parrot/fadt.c b/src/mainboard/google/parrot/fadt.c index 5ce9ab1..b96ec32 100644 --- a/src/mainboard/google/parrot/fadt.c +++ b/src/mainboard/google/parrot/fadt.c @@ -26,11 +26,11 @@ * code and the mainboard fadt. */ #define APM_CNT 0xb2 -#define CST_CONTROL 0x85 -#define PST_CONTROL 0x80 -#define ACPI_DISABLE 0x1e -#define ACPI_ENABLE 0xe1 -#define GNVS_UPDATE 0xea +#define CST_CONTROL 0x85 +#define PST_CONTROL 0x80 +#define ACPI_DISABLE 0x1e +#define ACPI_ENABLE 0xe1 +#define GNVS_UPDATE 0xea
void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) {