Hello coreboot fellows,
first I want to say, I feel pretty awkward bringing this up. I'm not a fan of regulations. But as it turns out, our community is growing (\o/) and with that growth the number of situations where regulation seems necessary increases too.
So, we already have Gerrit guidelines [1]. While they are most often not worth a look (common sense usually is enough), some people like to be reminded of them regularly. The latter is pretty annoying and doesn't seem to help.
I propose to add some lines what should happen when somebody delibe- rately ignores the guidelines. One such case that I often see is rubber-stamping of huge commits. Our guidelines say
"As a reviewer who approves (+2) a patch, you are responsible for the patch and the effect it has on the codebase."
I've never seen anyone taking responsibility for rubber-stamped code. Bigger additions seem to be always cleaned up by other folks. This led me to the following idea:
Reviewers who rubber-stamp bigger code additions will be demoted by one group on Gerrit. They can only return to the higher group after one hour per rubber-stamped, added line.
Sounds easy and fair, I'd say. What do you think? Of course, there are many other kinds of violations; feel free to bring more up. I just want to start the discussion.
Nico
[1] https://doc.coreboot.org/getting_started/gerrit_guidelines.html