Re: [coreboot] [PATCH] Add Asus M2A-VM support

[Myles Watson]

On Thu, Feb 12, 2009 at 8:12 AM, Carl-Daniel Hailfinger
 wrote:
> After lots of cleanups, bugfixes, feature extensions and testing, my
> diff to add Asus M2A-VM support to coreboot has shrunk almost to zero.

If it weren't for the socket difference, I'd be interested to see if
the dbm690t would just work with the Asus changes and only have one
target.
>                                            end
>                                    end
>                                    device pci 2.0 on end # PCIE P2P bridge (external graphics) 0x7913
>                                   device pci 3.0 off end # PCIE P2P bridge        0x791b
>                                   #device pci 3.0 off end # PCIE P2P bridge       0x791b
>                                  device pci 4.0 on end # PCIE P2P bridge 0x7914
>                                  device pci 5.0 on end # PCIE P2P bridge 0x7915
>                                  device pci 6.0 on end # PCIE P2P bridge 0x7916
>
> @@ -257,9 +257,9 @@
>                                        device pci 14.3 on # LPC        0x438d
>                                                chip superio/ite/it8712f
>                                                        device pnp 2e.0 off #  Floppy
>                                                           io 0x60 = 0x3f0
>                                                           irq 0x70 = 6
>                                                           drq 0x74 = 2
>                                                           #io 0x60 = 0x3f0
>                                                           #irq 0x70 = 6
>                                                           #drq 0x74 = 2

Why does it matter if you comment out settings for a device that's
off?  Same question for the pci 3.0 device above.

Thanks,
Myles