New patch version attached, but the compile error stays at the same state than before.
On Friday 21 August 2009 17:31:17 ron minnich wrote:
This is *almost* perfect. Questions and changes.
I think it would be possible to sparse some values in the mainboard directory out, but that's a todo after fixing compilation.
Index: src/cpu/amd/socket_AM2/Kconfig
--- src/cpu/amd/socket_AM2/Kconfig (revision 0) +++ src/cpu/amd/socket_AM2/Kconfig (revision 0) @@ -0,0 +1,30 @@ +config CPU_AMD_SOCKET_AM2
- bool
- default false
+config CPU_SOCKET_TYPE
- hex
- default 0x10
- depends on CPU_AMD_SOCKET_AM2
It's a type 0x10?
+config K8_REV_F_SUPPORT
- int
- default 1
- depends on CPU_AMD_SOCKET_AM2
Socket AM2 supports REV F? I don't know, just asking.
+config CPU_SOCKET_TYPE
- hex
- default 0x11
- depends on CPU_AMD_SOCKET_AM2
it's in here twice.
Index: src/cpu/amd/socket_AM2/Makefile.inc
--- src/cpu/amd/socket_AM2/Makefile.inc (revision 0) +++ src/cpu/amd/socket_AM2/Makefile.inc (revision 0) @@ -0,0 +1,14 @@ +obj-$(CONFIG_CPU_AMD_SOCKET_AM2) += socket_AM.o +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../model_fxx +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../dualcore +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../mtrr +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/tsc +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/mtrr +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/fpu +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/mmx +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/sse +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/lapic +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/cache +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/mtrr +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/pae +subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/smm
Just make these -y. This Makefile.inc is *conditionally* included from the src/cpu/amd/Makefile.inc. There's no reason to make them conditional in turn.
Let's go around one more time taking into account my comments. We are almost there.
ron