Re: [coreboot] [patch] add required info to not-matched vendor/device id

[Elia Yehuda]

On Fri, Nov 7, 2008 at 5:00 AM, Carl-Daniel Hailfinger <
[e-mail]> wrote:
> On 07.11.2008 03:47, Elia Yehuda wrote:
> > Signed-off-by: Elia Yehuda
>
> A small changelog (2 lines or so, more if you like) would be appreciated.

ok, i thought the title was informative enough... i'll try harder next
time!!! :-)
> > Index: src/devices/pci_rom.c
> >
> > --- src/devices/pci_rom.c    (revision 3698)
> > +++ src/devices/pci_rom.c    (working copy)
> > @@ -67,8 +67,10 @@
> >      printk_spew("PCI ROM Image, Vendor %04x, Device %04x,\n",
> >              rom_data->vendor, rom_data->device);
> >      if (dev->vendor != rom_data->vendor || dev->device !=
>
> rom_data->device)
> > {
> >    printk_err("Device or Vendor ID mismatch Vendor %04x, Device
> >
> > %04x\n",
> >           rom_data->vendor, rom_data->device);
> >    printk_err("Device or Vendor ID mismatch Vendor %04x, Device
>
> %04x "
> >           "(Vendor %04x, Device %04x)\n",
> >           rom_data->vendor, rom_data->device,
> >           dev->vendor, dev->device);
> >    return NULL;
> > }
>
> The patch was mangled by gmail. AFAIK that's an unfixable bug with the
> gmail web interface. Please attach the patch instead.

will do
> About the contents of the patch: The new message still requires people
> to read the source code. How about:
> "Device or Vendor ID mismatch: read Vendor %04x, Device %04x, expected
> Vendor %04x, Device %04x\n"

such a long line breaks the 80 column boundary. is that ok?
> Regards,
> Carl-Daniel