On 28/10/07 09:06 -0700, ron minnich wrote:
On 10/27/07, Peter Stuge peter@stuge.se wrote:
Please don't ack just because noone else does it. That defeats the purpose of the reviews.
no, what I meant was, "I will do the review and try to make sure the patch is clean"
Sorry for creating confusion. I'm not just going to ack for the sake of an ack :-); I was just very worried that we might have lost another board.
Which is a very reasonable and real fear.
It is very important to remember that most of the companies and vendors that come to this project are not here because they believe in the ideals of open source, or even because they want to create a world class product. In fact, forst most, this is their first foray into the world of open source. Many of them have been convinced to come here by employees, partners, vendors or customers. They are here to present their products because they believe that participation in LinuxBIOS is a good business move, but few want to spend a lot of valuable money and engineering resources on it - they want to dump the code and run, so to speak.
It is all well and good to hold the code to very high standards - and we should continue to do so as an open source community. But we also need to realize that, at this point, we are completely dependent on the vendors to advance this project. If they are willing to buy into the coding standards and the loftier ideas of the open source creedo, then more power to them, and we thank them. But if not, then *we* need to take up the slack, and handle the style and other issues that turn good code into great code. Tossing these back into the face of vendor who really would rather not be here is just incentive for them to storm off and say bad things about us behind our back. Peter's manifesto, while correct, and reflecting our best intentions, is sure not to help the matter at all. The vendors we so desperately need just don't buy into it. Sorry.
I'm not sure if SiS is coming back, and I wouldn't be surprised if they didn't.
Jordan