Re: [coreboot] [PATCH] Fix AMD 690 HIGH_TABLES

[Myles Watson]

On Wed, Oct 14, 2009 at 7:49 PM, Myles Watson  wrote:
> #if CONFIG_SOUTHBRIDGE_AMD_RS690  // I guess this could be board-specific
> too, since that's where these variables are defined.
> > +extern uint64_t uma_memory_base, uma_memory_size;
>
> I think the nicest thing to do would be to move the definitions of

uma_memory_* into the southbridge code.  It doesn't really belong in the
mainboard.  We could also protect it with CONFIG_GFXUMA.  I'd like to use
CONFIG_VIDEO_MB, but it looks like the code assigns the uma_memory_size
based on the size of main memory.  I guess since it wouldn't brick the
boards we could just use the defines and set it to 128M since that's for 1G
and up.  Are many people running these boards with 256 MB of RAM?

Thanks,
Myles