On Fri, Mar 19, 2010 at 8:43 AM, Stefan Reinauer stepan@coresystems.de wrote:
On 3/18/10 5:43 PM, Maximilian Thuermer wrote:
Hi all,
I am working with a Tyan S2912 board and fam10 Opterons and recently updated my coreboot environment. I stumbled across an error which I thought was already removed a while ago. The HT link offsets reported by function "AMD_CpuFindCapability" in init_cpus.c are not correct (they always evaluate to 0x08) and therefore do not comply with link offsets as specified by AMDs BKDG. Below is a simple fix which produces correct behavior - at least on my box. Dont know what side effects this might have on systems other than the PHY electrical settings and erratas not getting applied.
Looks good to me.. We can check it in as soon as we have a good Sign-off...
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
I agree, this change looks right.
Marc