Re: [coreboot] [PATCH] New Socket370 and Model 68x for CAR

[Joseph Smith]

> > > > > Index: src/cpu/intel/model_68x/model_68x_init.c
> > > > >
> > > > > --- src/cpu/intel/model_68x/model_68x_init.c (revision 0)
> > > > > +++ src/cpu/intel/model_68x/model_68x_init.c (revision 0)
> > > >
> > > > [..]
> > > > > +static struct cpu_device_id cpu_table[] = {
> > > >
> > > > Do add 680 here too. In fact, if you add 680 all the others can be
> > > > omitted.
> > >
> > > ok, why? 680 will cover everything?
> >
> > Yes. It will mask the ID with fff0
>
> ok
> > > > > { X86_VENDOR_INTEL, 0x0681 },
> > > > > { X86_VENDOR_INTEL, 0x0683 },
> > > > > { X86_VENDOR_INTEL, 0x0686 },
> > > > > { X86_VENDOR_INTEL, 0x068a },
> > > > > { 0, 0 },
> > > > >
> > > > > +};
> > > > >
> > > > > +static const struct cpu_driver driver __cpu_driver = {
> > > > > .ops =&cpu_dev_ops,
> > > > > .id_table = cpu_table,
> > > > >
> > > > > +};

Hmm. If I add 0x0680 and delete the others I get:

Initializing CPU #0
CPU: vendor Intel device 68a
CPU: family 06, model 08, stepping 0a
Using generic cpu ops (good)
Enabling cache
microcode_info: sig = 0x0000068a pf=0x00000010 rev = 0x00000000
microcode updated to revision: 00000001 from revision 00000000

----
Before I did not get the "Using generic cpu ops (good)" is that ok?