Re: [coreboot] New patch to review for coreboot: dc63ffb Fill out ChromeOS specific coreboot table extensions

[Peter Stuge]

Stefan Reinauer wrote:
> Fill out ChromeOS specific coreboot table extensions
>
> ChromeOS uses two extensions to the coreboot table:
> - ChromeOS specific GPIO description for onboard switches
> - position of verified boot area in nvram

..
> +++ b/src/include/boot/coreboot_tables.h
> @@ -195,6 +195,33 @@ struct lb_framebuffer {
>    uint8_t reserved_mask_size;
>  };
>
> +#define LB_TAG_GPIO	0x0013
>
> +struct lb_gpio {
> uint32_t port;
> uint32_t polarity;
> uint32_t value;
>
> +#define GPIO_MAX_NAME_LENGTH 16
>    uint8_t name[GPIO_MAX_NAME_LENGTH];
>
> +};
>
> +struct lb_gpios {
> uint32_t tag;
> uint32_t size;
> uint32_t count;
> struct lb_gpio gpios[0];
>
> +};
>
> +#define LB_TAG_VDAT	0x0015
> +struct lb_vdat {
> uint32_t tag;
> uint32_t size;
> void	*vdat_addr;
> uint32_t vdat_size;
>
> +};

Maybe it should be made clear also in the names that these tags are
chromeos specific?

//Peter