Re: [LinuxBIOS] [PATCH] Support for Winbond W83627EHG Super I/O

[Lu, Yinghai]

Thanks.

After you commit it, I would produce another patch about
1. UNITID shifting support
2. one Typo in console_printk*...

YH

-----Original Message-----
From: Stefan Reinauer [mailto:[e-mail]] 
Sent: Wednesday, February 28, 2007 3:47 AM
To: Lu, Yinghai
Cc: Stefan Reinauer; Uwe Hermann; [e-mail]
Subject: Re: [LinuxBIOS] [PATCH] Support for Winbond W83627EHG Super I/O

* Lu, Yinghai  [070205 18:09]:
> USB DEBUG port support.

I committed this now, but I am unwilling to let this printk_ram stuff go
in like that. We do not want yet another set of printk functions that
have to be used with ifdefs spread in dozens of files. Can you please
hook this up cleanly and against the CURRENT svn?

There's also smaller stuff that seems or seems not to be missing, like
randomly commented in and out functions in yh_rest_of_patch.patch.

I will not go into further trouble of merging these changes now. If
anyone feels this is needed, please help.

I made a new, somewhat cleaned up version of yh_rest_of_patch.patch
But it is far from ready to go in.
> -----Original Message-----
> From: [e-mail]
> [mailto:[e-mail]] On Behalf Of Stefan Reinauer
> Sent: Saturday, February 03, 2007 7:31 AM
> To: Uwe Hermann
> Cc: [e-mail]
> Subject: Re: [LinuxBIOS] [PATCH] Support for Winbond W83627EHG Super

I/O
> Uwe Hermann wrote:
> > Add support for the Winbond W83627EHG Super I/O.
> >
> > Signed-off-by: Yinghai Lu 
> > Signed-off-by: Uwe Hermann
>
> applied.
> > This is from Yinghai's huge patch. I added missing license headers
> > (Yinghai please complain if any of them is incorrect!), fixed some
> > coding style issues and added a few comments.
>
> What's still missing from Yinghai's patch now?