Re: [coreboot] Coreboot patches for v2 with SeaBIOS

[Myles Watson]

> -----Original Message-----
> From: Marc Jones [mailto:[e-mail]]
> Sent: Friday, February 27, 2009 10:51 AM
> To: Myles Watson
> Cc: Stefan Reinauer; Coreboot
> Subject: Re: [coreboot] Coreboot patches for v2 with SeaBIOS
>
> On Fri, Feb 27, 2009 at 10:42 AM, Myles Watson  wrote:
> > Does this work for you with 4G of RAM?  I don't have a Kontron board,
> > but I copied the implementation to the amdk8 northbridge code.  It
> > works for me when I have the RAM "boosted" and it works when I boot
> > with less than 4G, but if I boot with 4G it tries to put the high
> > tables in the PCI decode space since they overlap.
> >
> > Besides that the patch is working well for me, and I'd like to see it
>
> merged.
> > If it works in the 4G case and I just didn't implement it right for K8:
> >
> > Acked-by: Myles Watson
>
> Do you have an off by 1 problem? That would cause the problem @ 4GB as
> you described.

I'm confused ( again :) )

I'm not sure where the off by one problem would be.

I thought the problem was that when you have the top of RAM at 0x100000000
and then subtract some small number from it you end up at 0xffff0000, which
isn't where you should be accessing normal RAM, or reserving it for ACPI.

Thanks,
Myles