Re: [coreboot] Resource allocator in v2

[Carl-Daniel Hailfinger]

On 09.05.2009 00:26, Myles Watson wrote:
> > -----Original Message-----
> > From: Carl-Daniel Hailfinger [mailto:[e-mail]]
> > Sent: Friday, May 08, 2009 4:21 PM
> > To: Myles Watson
> > Cc: 'coreboot'
> > Subject: Re: [coreboot] Resource allocator in v2
> >
> > On 09.05.2009 00:16, Myles Watson wrote:
> > > Does anyone have the stomach for reviewing patches so I can bring the
> > > resource allocator from v2 to v3?
> >
> > Bring the resource allocator fro v2 to v3? Wasn't the original v3
> > resource allocator a copy of the v2 allocator? In that case, reverting
> > all resource allocator patches in v3 should fix this. Hmmm. Not good.
>
> Sorry.  v3 to v2. Long day.

Oh lucky day. v3 to v2 makes me happy. :-)
> > > My board is broken and it's harder to debug because of the mutual
> >
> > recursion.
> >
> > Which board is this?
>
> Tyan s2892.  Adding devices changes the order in which the resources are
> enumerated and breaks a lot of weird things.
> > > The other alternative is for me to just keep a monster patch on my
> >
> > stack,
> > > but then it will never get merged.
> >
> > I'd review, but my resource allocator knowledge is seriously lacking. I
> > gave up while trying to figure out reasonable device trees for HT+PCI
> > and resource inheritance.
>
> I don't think it's that bad if we take out the mutual recursion.  In my
> opinion that makes it nearly impossible to follow.

OK, I'll try to review, but please don't trust them alone.

Regards,
Carl-Daniel