Tobias Diedrich wrote:
Uwe Hermann wrote:
While using the builtin Add() directly works:
Signed-off-by: Tobias Diedrich ranma+coreboot@tdiedrich.de
...this solution looks nice and readable too.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Thanks, committed as r6132.
Maybe a bit too quick. I didn't test-boot this because iasl did not complain, but now that I did boot for another reason I get: [ 0.111215] ACPI: Core revision 20100428 [ 0.115970] ACPI Error: Found unknown opcode 0xE4 at AML address e07ee578 offset 0x14, ignoring (20100428/psloop-141) [ 0.130114] ACPI Error: Found unknown opcode 0xE4 at AML address e07ee578 offset 0x14, ignoring (20100428/psloop-141) [ 0.140090] ACPI Exception: AE_CTRL_PENDING, While creating Arg 1 (20100428/dsutils-763) [ 0.148689] ACPI Error: Found unknown opcode 0xC3 at AML address 00000008 offset 0x1F811AA4, ignoring (20100428/psloop-141) [ 0.160027] ACPI Error: Found unknown opcode 0xE2 at AML address 00000009 offset 0x1F811AA5, ignoring (20100428/psloop-141) [ 0.172338] ACPI Error: Found unknown opcode 0xF0 at AML address 0000000b offset 0x1F811AA7, ignoring (20100428/psloop-141) [ 0.182325] ACPI Error: Found unknown opcode 0x39 at AML address 00000015 offset 0x1F811AB1, ignoring (20100428/psloop-141) [ 0.192354] ACPI Error: Found unknown opcode 0xC0 at AML address 00000017 offset 0x1F811AB3, ignoring (20100428/psloop-141) [ 0.202386] ACPI Error: Found unknown opcode 0xFE at AML address 00000021 offset 0x1F811ABD, ignoring (20100428/psloop-141) [ 0.219243] ACPI Error: Found unknown opcode 0xF0 at AML address 00000023 offset 0x1F811ABF, ignoring (20100428/psloop-141)
And changing the Add(DEFAULT_PMBASE, PCNTRL) back to 0xe410 fixes it. Either iasl is buggy or the linux kernel... :/