Re: [coreboot] [PATCH] Quick and dirty Asrock 939A785GMH support

[Stefan Reinauer]

On 3/17/10 12:25 AM, Rudolf Marek wrote:
> Hi again,
>
> So I think I'm wasting all my good luck for this year:
> Index: rs780_gfx.c
>
> --- rs780_gfx.c    (revision 5227)
> +++ rs780_gfx.c    (working copy)
> @@ -817,6 +817,11 @@
>      .vendor = PCI_VENDOR_ID_ATI,
>      .device = PCI_DEVICE_ID_ATI_RS780E_INT_GFX,
>  };
> +static struct pci_driver pcie_driver_780e __pci_driver = {
> .ops = &pcie_ops,
> .vendor = PCI_VENDOR_ID_ATI,
> .device = 0x9710,
>
> +};

With "const" for the driver and Signed-off-by, this is
Acked-by: Stefan Reinauer

Maybe we should use the PCI ID instead of PCI_DEVICE_ID_ATI_RS780E_INT_GFX
as this would make such bugs easier to find, so you can spare some luck :-)

Stefan