-----Original Message----- From: Stefan Reinauer [mailto:stepan@coresystems.de] Sent: Thursday, March 06, 2008 7:07 AM To: Myles Watson Cc: Coreboot Subject: Re: [coreboot] Makefile simplification for v3
- Myles Watson mylesgw@gmail.com [080305 19:27]:
$(Q)# QEMU wants bios.bin: $(Q)# Run "qemu -L build/ -serial stdio -hda /dev/zero".
- $(Q)printf " CP $(subst $(shell pwd)/,,$(obj)/bios.bin)\n"
- $(Q)cp $@ $(obj)/bios.bin
- $(Q)# printf " CP $(subst $(shell pwd)/,,$(obj)/bios.bin)\n"
- $(Q)# cp $@ $(obj)/bios.bin $(Q)echo "Coreboot ROM Image:" > $(obj)/coreboot.map $(Q)$(obj)/util/lar/lar -l $(obj)/coreboot.rom >>
$(obj)/coreboot.map
$(Q)(echo; echo "Stage 0/1 Map:") >> $(obj)/coreboot.map
I think this sneaked in... Please make sure you don't commit this.
You're right. It should be a separate patch. I'll make sure I don't commit it with the rest of this patch.
I think it would be correct to remove it because it is mainboard specific. Someone who wants to automate testing could use a symbolic link to coreboot.rom from their BIOS directory.
Myles