Re: [coreboot] r3416 - trunk/util/flashrom

[Peter Stuge]

On Mon, Jul 07, 2008 at 07:50:50AM +0200, Stefan Reinauer wrote:
> [e-mail] wrote:
> > Author: hailfinger
> >
> > r3415 removed symbolic constants for device IDs by accident.
> > flash.h is a database of known IDs, whereas flashchips.c is a database
> > of chips for which support has been implemented. Keep it that way.
>
> NACK. This was done on purpose, not by accident. As discussed before,
> we will not pursue the useless facility of defines for those IDs
> anymore because they serve no purpose.

Agreed. Carl-Daniel, please revert this.

//Peter