Re: [coreboot] [commit] r5008 - trunk/util/msrtool

[Joseph Smith]

On Fri, 15 Jan 2010 21:27:15 +0100, Stefan Reinauer 
wrote:
> On 1/15/10 8:20 PM, Peter Stuge wrote:
> > [e-mail] wrote:
> > > Support for the AMD Geode GX2 Processors to Msrtool.
> > > It seems to work as it was tested
> >
> > Please do not accept "it seems to work" for new register
> > descriptions, always review them against the available
> > documentation. Thanks.
>
> I figured nobody has the time to check this, not even the author of
> msrtool.
>
> Should someone ever use this code on a Geode GX2 system again, the code
> is there and can be improved now.
>
> That's much better than annoying contributors and letting contributions
> going down the drain.

I have a AMD PIC with a GX2 on my todo list:-)