Re: [coreboot] [PATCH] superiotool: fix wrong IT8718F keyboard value

[Uwe Hermann]

On Thu, Oct 09, 2008 at 08:26:09AM -0400, Josh wrote:
> According to IT8718F_V0 3_(for C version).pdf, it looks like
> 0xf0 should be 0x08.
>
> Signed-off-by: Josh Profitt
> Index: util/superiotool/ite.c
>
> --- util/superiotool/ite.c	(revision 3642)
> +++ util/superiotool/ite.c	(working copy)
> @@ -295,7 +295,7 @@
>    		 0x00,NANA,NANA,EOT}},
>    	{0x5, "Keyboard",
>    		{0x30,0x60,0x61,0x62,0x63,0x70,0x71,0xf0,EOT},
> 	{0x01,0x00,0x60,0x00,0x64,0x01,0x02,0x00,EOT}},
> 	{0x01,0x00,0x60,0x00,0x64,0x01,0x02,0x08,EOT}},

Maybe, maybe not. Page 56 says 0x08, but on page 32 it says 0x00. The
datasheet contradicts itself here, and we don't know which one is
actually the correct default. We should probably document this in the
code, though.

The difference is that KBC clock is either 8 or 12 MHz, which is
board-dependent, unclear what could be the default for the chip.

Uwe.