On 28.02.2008 12:52, Carl-Daniel Hailfinger wrote:
On 28.02.2008 08:55, Corey Osgood wrote:
Signed-off-by: Corey Osgood corey.osgood@gmail.com
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
We may want to rewrite genfadt in a way where all constant members of fadt are initialized at compile time instead of at run time. This probably even decreases the size of the binary and improves speed at run time.
The more I look at the code, the less I believe the two tools with completely different purposes should be in one file. If you look at flashrom and superiotool and their modular multi-file structure even though they have only one purpose, the merging of genfadt and gendsdt is really the wrong thing to do.
I hereby retract my signoff until we have discussed whether the merge makes sense for any reason besides disliking small utilities.
Regards, Carl-Daniel