Re: [coreboot] [PATCH] v3: Improve printk reliability

[Peter Stuge]

Carl-Daniel Hailfinger wrote:
> This patch tries to make printk more readable and reliable.

I like the idea.
> Introduce "<almost NULL>" for string arguments with addresses
> below 0x400.

I would like the message to be more informative. Include the address
somehow..

"<near-NULL %03x>" or so?

(No, I don't want to make printf() recurse, but you get my idea. :)
> The idea is to catch garbage strings from stray pointers and print
> "<GARBAGE>" instead.

Again request more informative text. For example I think
"<non-ASCII characters>" would be much nicer.
> Signed-off-by: Carl-Daniel Hailfinger

If you agree with my requests I say

Acked-by: Peter Stuge