Re: [coreboot] [PATCH] Simplify device enabling and initialization

[Myles Watson]

On Sun, Jun 20, 2010 at 8:11 PM, Ward Vandewege  wrote:
> Hi Myles,
>
> Everything seems fine with either patch - but there are some differences in
> the boot output.
>
> I also ran the 'sensors' command.
>
> Output here:
>
> http://ward.vandewege.net/coreboot/s2881/20100617-myles/
>
> I ran 4 tests: stock r5635 (head), stock r5632 (revision prior to this
> changeset), r5635 + patch 1 and r5635 + patch 2.

Thanks for testing.

It looks like only 5632 has the "ADT7463 properly initialized"
message.  One problem is that patch 2 was meant to be applied after
patch 1, so the device didn't end up in the tree for that run.  I'll
have to think about why the only message from the new device with
patch 1 is "I2C: 00:d0 missing read_resources"  For some reason it
doesn't look like it got the correct ops.

I wonder why the temperature values look right in all cases.  Does it
need to be cold booted in order for the initialization to be needed?

Thanks,
Myles

Thanks,
Myles