On Fri, Oct 01, 2010 at 11:55:49AM -0600, Myles Watson wrote:
Modified: trunk/src/cpu/intel/model_106cx/cache_as_ram.inc trunk/src/cpu/intel/model_6ex/cache_as_ram.inc trunk/src/cpu/intel/model_6fx/cache_as_ram.inc
It looks like src/cpu/intel/car/cache_as_ram.inc could use the same
love.
Hm, I think I already cleaned up that one.
Sorry about that. I was trying to diff it with model_6ex/cache_as_ram.inc, and lots of the comments, indenting, etc. didn't match yet.
I'd be interested to see how much uglier it made these files to combine them. There's very little difference between the 6ex & 6fx code.
Indeed, I'll post a patch to unify 6ex, 6fx, and 106cx at the very least, their differences are minimal.
The other ones are a bit different, but I'll post a few more patches to factor out common stuff and further simplify the code, which might allow us to factor out more generic code maybe, we'll see.
Thanks for doing it! Myles