Re: [coreboot] [PATCHes] mostly Kbuild fixes for out of tree build, Kconfig support in abuild

[Stefan Reinauer]

On 1/29/10 9:16 PM, Myles Watson wrote:
> > don't turn on WARNINGS_AS_ERRORS for Qemu per default
>
> I disagree with this change.  I think it should be noticed when
> changes add warnings to a target that is free of them.  I think the
> goal should be to be able to turn this on for all targets.  There have
> been several times that warnings pointed out breakage.  Ignoring them
> seems counterproductive.

Hm... It did not compile without warnings for me when I tried, so that's
why I disabled it at some point.

I generally agree with what you're saying.  Actually I manually deleted
the  "add -Werror-implicit-function-declaration to CFLAGS" part of my
patch because I figured people would feel no love for me if I left it
in. I think it should go in then, too.

Stefan