Re: [LinuxBIOS] patch: lx northbridge use spd_read_byte and add debug prints

[ron minnich]

On Nov 27, 2007 8:50 AM, Peter Stuge  wrote:
> On Tue, Nov 27, 2007 at 08:24:15AM -0800, ron minnich wrote:
> > .. banner
>
> Could this be made more generic/common for more boards?

sure, I could put it in lib/console.c if people want it.
> > +/**
> > Halt and Catch Fire. Print an error, then loop, sending NULLs on serial port,
> > to ensure the message is visible.
> > */
> >
> > +void hcf(void)
> > +{
> > printk(BIOS_EMERG, "DIE\r\n");
> > /* this guarantees we flush the UART fifos (if any) and also
> >  * ensures that things, in general, keep going so no debug output
> >  * is lost
> >  */
> > while (1)
> >         printk(BIOS_EMERG, "\r");
> >
> > +}
>
> Could this be a common die() instead?

yes. I got burned in years past with UARTs that had fifos. Rather than
halt I would rather this. You want a patch for console.c?

ron