Re: [coreboot] [PATCH]Move SET_FIDVID to Kconfig

[Stefan Reinauer]

* Patrick Georgi  [101116 17:29]:
> Am 13.11.2010 09:16, schrieb Patrick Georgi:
> > Hi,
> >
> > I updated the SET_FIDVID patch to match the current tree, and also
> > validated it against the pre-patch tree. To do this, I added to
> > src/cpu/amd/model_*xx/fidvid.c a bunch of
> > #if SET_FIDVID
> > #warning SET_FIDVID
> > #endif
> > style blocks to the pre-patch tree, for all SET_FIDVID* flags, and with
> > CONFIG_ prefix to the patched tree, and ran abuild.
> >
> > After that, I mangled all coreboot-builds/*/make.log to drop the CONFIG_
> > prefixes and other minor differences (line numbers of the
> > warnings/errors), and diffed the result of both trees. This exposed one
> > configuration change in gigabyte/ma78gm, which I fixed.
> > All boards now show identical configuration with and without this patch.
> >
> > ==
> > Move the SET_FIDVID* family of configuration options to Kconfig and
> > make their defaults more obvious.
> >
> > Signed-off-by: Patrick Georgi
>
> ping?

Acked-by: Stefan Reinauer