Re: [coreboot] AMD HT link frequency limit configuration patch

[Peter Stuge]

Timothy Pearson wrote:
> This patch allows the user to select a maximum HyperTransport link
> frequency.

I like this a lot.
> +++ src/northbridge/amd/amdht/h3finit.c	(working copy)
> @@ -1327,7 +1327,25 @@
>
> for (i = 0; i < pDat->TotalLinks*2; i += 2)
>    {
> cbPCBFreqLimit = 0xFFFF;
>
> +#if CONFIG_LIMIT_HT_SPEED_200
> cbPCBFreqLimit = 0x0001;		// 200MHz

But shouldn't this also be tied in with Kconfig files, with the
correct maximum selected for each board? (An expert mode could allow
overclocking though.)

Oh, and the comments seem redundant to me, especially if Kconfig also
gets involved in this. Maybe it already is, even?

//Peter