Re: [coreboot] [PATCH] s289x ACPI fix

[Peter Stuge]

Stefan Reinauer wrote:
> > > /* IRQ9 ACPI active low. */
> > >    current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)
> > > current, 0, 9, 9, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW);
> > > current, 0, 9, 9, MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_LOW);
> >
> > This is definately something that should not be unique per board.
>
> Most of that code is common code,... except calling the common
> function with board specific parameters..

Right.
> There might be other boards with similar function calls, but it's
> still board specific code.

I was thinking of IRQ9 specifically. Is there a single board where it
should not be edge triggered to make Linux (and probably others)
happy?

//Peter