Re: [coreboot] [PATCH] AMD MMCONF Support

[Myles Watson]

> > Instead of adding the reserved area directly to the coreboot tables,
> > you should add it before resource allocation and let the rest happen
> > automatically.
>
> I'm sorry, I'm not at all familiar with the resource allocation
> framework.  I tried to model this on the corresponding code for relevant
> Intel mainboards.  How would you change it, precisely?

I'd forgotten that this was the way it was done.  I agree that you did
it the same way that it had been done before.  It's often hard to
review a patch without reviewing the mechanisms it uses.

Thanks,
Myles