Re: [coreboot] [commit] r6127 - in trunk/src: mainboard/asus/p2b northbridge/intel/i440bx/acpi southbridge/intel/i82371eb southbridge/intel/i82371eb/acpi

[Tobias Diedrich]

Stefan Reinauer wrote:
> On 11/27/10 1:40 AM, repository service wrote:
> > +++ trunk/src/mainboard/asus/p2b/dsdt.asl	Sat Nov 27 10:40:16 2010	(r6127)
> > @@ -0,0 +1,101 @@
>
> ...
> > +DefinitionBlock ("DSDT.aml", "DSDT", 2, "CORE  ", "COREBOOT", 1)
> > +{
> > /* Define the main processor.*/
> > Scope (_PR)
> > {
> > /* Looks like the P_CNT field can't be a method or name
> >  * and has to be hardcoded to 0xe410 or generated in SSDT */
> > Processor (CPU0, 0x01, 0xe410, 0x06) {}
> > }
>
> The specified IO port is most likely wrong. As the comment mentions, the
> SSDT is a good place for that. A preprocessor define used both in the
> CPU init code and in the asl would solve the problem without an SSDT.
> For some info on CPU SSDT creation on intel check out
> src/cpu/intel/speedstep/acpi.c

The IO port is ok (and I wrote the comment myself ;)):
DEFAULT_PMBASE is 0xe400
PCNTRL reg offset is 0x10

Using the preprocessor will probably work too if iasl can do simple
arithmetic (likely yes), I'll look into that.