Re: [coreboot] [PATCH] v3: Fix parts of the Winbond W83627HF dts

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Uwe Hermann
> Sent: Saturday, November 15, 2008 10:12 AM
> To: [e-mail]
> Subject: [coreboot] [PATCH] v3: Fix parts of the Winbond W83627HF dts
>
> See patch.
> Fix some incorrect entries in superio/winbond/w83627hf/dts.
>
> The hardware monitor defaults as per datasheet are 0x0000 / 0, but on
> hardware that uses this functionality it seems to be 0x290 / 5 often.>

I think that means that it should be 0x290 /5 in the dts.  The dts should
reflect the common case in actual use, not the power on defaults of the
registers.  Hopefully that will minimize the need to override defaults in
the mainboard dts.

I'll Ack the other changes though.

Acked-by: Myles Watson

Thanks,
Myles