Re: [coreboot] http://review.coreboot.org/#/c/493/: Add mainboard supermicro x7db8

[Paul Menzel]

Dear Manasa,

I am sorry for the late reply and thank you for your contributions.

Before going further please make sure you disable digest mode in your
Mailman preferences [1], so that threading is kept when you reply to
messages.

Unfortunately you took a patch for review, which was not meant to be
committed. Sven commented the following [2].

Unfinished, only pushed for backup purposes

Am Mittwoch, den 23.05.2012, 17:55 +0530 schrieb manasa gv:
> From: Manasa GV
>
> This patch is to file x7db8.Build(Jenkins) results failed for patch
> set1 in patch493.Test results showing error. So i added cmos.layout
> file.Later i done abuild,then also it is showing errors. Errors are-
> need to add smbus.c, smbus.h ,early_setup.c file for Southbridge
> i63xx.
> So please suggest me to add these files.

I think there are two options.

1. Either contact Sven Schnelle and ask him, if he can use your
contributions and how you can help.

2. Or, register with Gerrit and push an updated patch with the change ID
in the commit message of the patch you are updating.
> Signed-off-by: manasa gv

Please add a space before the email address. You can add Signed-off-by
lines with Git by appending `-s` to most commands. Two examples:

$ git commit -s
    $ git format-patch -s -1

But currently Gerrit is used for patch review in coreboot.
> src/mainboard/supermicro/x7db8/cmos.layout |   72 ++++++++++++++++++++++++++++
> 1 files changed, 72 insertions(+), 0 deletions(-)
> create mode 100644 src/mainboard/supermicro/x7db8/cmos.layout

[…]

Thanks,

Paul

[1] http://www.coreboot.org/mailman/options/coreboot
[2] http://review.coreboot.org/#/c/493/