On Mon, Oct 12, 2009 at 4:17 PM, Uwe Hermann uwe@hermann-uwe.de wrote:
On Mon, Oct 12, 2009 at 02:09:03PM -0600, Myles Watson wrote:
+config MAXIMUM_CONSOLE_LOGLEVEL_8
- bool "8: BIOS_SPEW"
BIOS_SPEW is 9, not 8. Could you fix it?
Hm, nope, I think all Config.lb files are wrong here, they should use 8.
#define BIOS_DEBUG 7 /* debug-level messages */ #define BIOS_SPEW 8 /* Way too many details */
Using 9 has the same effect as using 8 I guess.
Nope. Spew messages don't show up anymore.
LOGLEVEL = 8:
coreboot-2.3" Tue Oct 13 07:40:07 MDT 2009 starting... Copying coreboot to RAM. Jumping to image.
Check fallback/coreboot_ram Stage: load fallback/coreboot_ram @ 1048576/106496 bytes, enter @ 100000 Stage: done loading. Jumping to image.
coreboot-2.3 Tue Oct 13 07:40:07 MDT 2009 booting...
LOGLEVEL = 9:
coreboot-2.3" Tue Oct 13 07:43:57 MDT 2009 starting... Copying coreboot to RAM. Jumping to image.
Check CBFS header at fffeffe0 magic is 4f524243 Found CBFS header at fffeffe0 Check fallback/coreboot_ram Stage: load fallback/coreboot_ram @ 1048576/106496 bytes, enter @ 100000 Stage: done loading. Jumping to image.
Attached patch fixes it.
There's a strange mix of comparisons, which makes it harder to tell what's going on. There are also lots of functions that do these checks. Hopefully I didn't miss any. I checked a few values with console_debug.diff.
While I was fooling with it, I made Kconfig ensure that MAXIMUM_CONSOLE_LOGLEVEL >= DEFAULT_CONSOLE_LOGLEVEL to minimize the number of test cases I needed.
Signed-off-by: Myles Watson mylesgw@gmail.com
Thanks, Myles