On 13.11.2008 02:41, Peter Stuge wrote:
Carl-Daniel Hailfinger wrote:
we want to keep Geode targets consistent.
Says who?
I say so and my clone agrees. ;-)
If a board is unique and we can't abstract in general code then mainboard/ code is fine.
If the abstraction works for all the other boards, there is no reason to have different codebases except to confuse people who want to port a new similar board.
We have lots of places in v2 where people made some change to one specific board, but the change would have applied to lots of boards. Later on, nobody could recall offhand why the files were different. To be honest, the amount of code duplication we have in v2 with little arbitrary changes sprinkled all over the map is one of the biggest reasons why I try to avoid v2 wherever possible. Diffing two boards will usually give you lots of differences which are in no way related to the board configuration/hardware.
Regards, Carl-Daniel