Issue #421 has been updated by Sergii Dmytruk.
Can you explain what use case you have that requires you to use multiple algorithms?
I'll let Krystian and Michał correct me, but I'm not sure if we have an actual need for multiple algorithms right away. The API change is probably motivated by the fact that agile format supports multiple algorithms unlike the coreboot-specific one.
And why is it not enough to just call tpm_extend_pcr() several times, once for each algorithm?
This won't work well with `tcpa_log_add_table_entry()`, which will then add a log entry per algorithm. `tpm_extend_pcr()` would be updated for consistency here, but it's not strictly necessary.
---------------------------------------- Cleanup #421: Change API of functions taking hash as an argument https://ticket.coreboot.org/issues/421#change-1184
* Author: Krystian Hebel * Status: New * Priority: Normal * Target version: none * Start date: 2022-10-12 ---------------------------------------- All existing functions that take a digest as an input assume that only one hashing algorithm is used at a time. Crypto agile format entry can (and should) log every used PCR bank in one entry for a given measurement. To make it work, some of the arguments must be changed, e.g.:
- pass number of algorithms used; - instead of algorithm ID, pass a pointer to array of such IDs, with size equal to above; - instead of hash, pass a pointer to array of hashes, with size and order as above.