Re: [coreboot] [PATCH] s289x ACPI fix

[Stefan Reinauer]

Peter Stuge wrote:
> > @@ -61,7 +74,7 @@ unsigned long acpi_fill_madt(unsigned lo
> >
> > /* IRQ9 ACPI active low. */
> >    current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)
> > current, 0, 9, 9, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW);
> > current, 0, 9, 9, MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_LOW);
>
> This is definately something that should not be unique per board. I
> expect not just Tyan boards will have this code. Could it be moved
> out to a common place?

Most of that code is common code,... except calling the common function
with board specific parameters.. There might be other boards with
similar function calls, but it's still board specific code.

Stefan