Re: [LinuxBIOS] r2550 - trunk/LinuxBIOSv2/util/flashrom

[Stefan Reinauer]

Peter Stuge wrote:
> On Fri, Feb 09, 2007 at 06:26:09PM +0100, Segher Boessenkool wrote:
> > Signed-off-by means "I am (in part) responsible for this
> > ending up in thid repo", i.e., you wrote part of the patch
> > or you were on the path pushing it in.
> >
> > Acked-by is used as a comment "looks fine by me" when not
> > taking direct action yourself.
>
> Does commiting constitute "on the path pushing it in" ?
>
> Ie. if I review and then commit, should I sign off or ack?

Not as a necessary pre-condition.

* If you did not work on the patch, you don't have to sign it off.

* If you don't agree to the patch or have not reviewed it (but check it
in because you trust the other reviewers who acked the patch), you
should not ack it.

Stefan