Re: [coreboot] [PATCH]The resource allocator does not like zero-sized fixed resources

[Myles Watson]

On Wed, Aug 19, 2009 at 10:14 AM, Patrick Georgi wrote:
> Hi,
>
> attached patch fixes a small issue with the resource allocator. In a loop in
> which only fixed resources are processed, zero-sized resources were able to
> modify the limits used for resource allocation in a later phase. This leads
> to overlapping resources on kontron.
> I had a patch for that a while ago already, but this one is much cleaner and
> much more obvious in its intent.
> If you think there shouldn't be zero-sized fixed resources, please take a
> look at src/devices/pci_device.c, line 331. There, a fixed resource with no
> size is created, and there is no obvious value to set for size.

The problem is that they have bogus limits, not that they have no
size.  Even if you commit this fix, you should fix the incorrect
limits.  They are two different problems.
> Even if there shouldn't be such resources, I think it's still good to
> prevent them from causing trouble if they appear.

My only objection is that it masks the real problem.

Thanks,
Myles