Hmm... well, I just uploaded a CL that clearly breaks one of the tests, and Jenkins still gave me a Verified+1: https://review.coreboot.org/80788
I also don't see any info about the tests running on the test report (https://qa.coreboot.org/job/coreboot-gerrit/252941/testReport/(root)/). So if the tests are running (and the code you pointed out strongly looks like they should be), it's probably a problem with reading back the test results? How does Jenkins collect those XML files?
On Tue, Feb 27, 2024 at 7:04 PM Martin Roth gaumless@tutanota.com wrote:
Hey Julius, Here's what we running: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/main/util/...
Martin Feb 27, 2024 at 18:31 by jwerner@chromium.org:
Hi,
We've had unit test support in libpayload for over two years now, but I just noticed that it doesn't look like we're actually running them in the CI? E.g. if I look through a test run like this https://qa.coreboot.org/job/coreboot-gerrit/252761/testReport/(root)/ I can't find them anywhere (most of them have confusingly similar names with coreboot unit tests, but "fmap_locate_area-test" is a unique one).
Is that intended or an oversight? Would it be easy to fix? (I'm not super familiar with how the tests are integrated into Jenkins, but the libpayload framework is pretty much a direct copy of the coreboot framework, so if we can run the coreboot ones hopefully it should be easy to run the libpayload ones as well?) _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org