Re: [coreboot] [flashrom][patch] enable/use flash chip read/erase return codes

[Carl-Daniel Hailfinger]

Hi Stephan,

On 26.05.2009 02:51, Stephan GUILLOUX wrote:
> Use chips read/erase return codes. erase() is not
> fully modified, though.
> flash_read() is unchanged, as I also have a patch pending in this area.
>
> Signed-off-by: Stephan Guilloux
>
> Index: flashrom-read-return-code/trunk/it87spi.c
> [...]
> Index: flashrom-read-return-code/trunk/sb600spi.c
> [...]

I just sent a patch which refactors reading and probably conflicts with
this part of your patch.
> Index: flashrom-read-return-code/trunk/flashrom.c
>
> --- flashrom-read-return-code/trunk/flashrom.c    (révision 547)
> +++ flashrom-read-return-code/trunk/flashrom.c    (copie de travail)
> @@ -208,12 +208,19 @@
> if (flash->read(flash, buf2)) {
>    printf("FAILED!\n");
>    fprintf(stderr, "ERROR : flashrom cannot read this flash chip.\n");

This error message is misleading. It's not the fault of the flash chip.
I think the "FAILED" output is enough.
> @@ -286,15 +293,28 @@
> if (flash->erase(flash)) {
>    printf("FAILED!\n");
>    fprintf(stderr, "ERROR: flashrom cannot erase this flash chip.\n");

Same here and in other places in the patch.

Can you take a look at my patch and check if it fixes the issues you
pointed out in the first part of your patch?

Can you resubmit the second part of your patch with changed error messages?

Thanks.

Regards,
Carl-Daniel