Florian Zumbiehl just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/436
-gerrit
commit 76533a84e63e9953c82df9898d4de6930c5a1183 Author: Florian Zumbiehl florz@florz.de Date: Mon Nov 21 02:51:01 2011 +0100
k8 raminit: comment out code that sets Memory DQ Drive Strength
It is unknown what exactly this code was intended to do, but as it stands, it sets Memory DQ Drive Strength to be reduced by 30%, which is a bad idea because of erratum 114, so the code is just commented out for now.
Change-Id: I08e4752923c286f9d22c1bab562f3bb3678742dd Signed-off-by: Florian Zumbiehl florz@florz.de --- src/cpu/amd/model_fxx/fidvid.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/cpu/amd/model_fxx/fidvid.c b/src/cpu/amd/model_fxx/fidvid.c index 6395a1e..77ff084 100644 --- a/src/cpu/amd/model_fxx/fidvid.c +++ b/src/cpu/amd/model_fxx/fidvid.c @@ -44,11 +44,16 @@ static void enable_fid_change(void) dword = 0x04e2a707; pci_write_config32(PCI_DEV(0, 0x18 + i, 3), 0xd4, dword);
+#if 0 +/* It is unknown what exactly this code was intended to do, but as it stands, + * it sets Memory DQ Drive Strength to be reduced by 30%, which is a bad idea + * because of erratum 114, so the code is just commented out for now. */ /* disable the DRAM interface at first, it will be enabled * by raminit again */ dword = pci_read_config32(PCI_DEV(0, 0x18 + i, 2), 0x94); dword |= (1 << 14); pci_write_config32(PCI_DEV(0, 0x18 + i, 2), 0x94, dword); +#endif
dword = 0x23070700; /* enable FID/VID change */ // dword = 0x00070000; /* enable FID/VID change */